Skip to content

feat: implement avg and stddev for Int256 by float64 - #9217

Merged
shanicky merged 6 commits into
mainfrom
peng/num256-agg-2
Apr 17, 2023
Merged

shanicky merged 6 commits into
mainfrom
peng/num256-agg-2

Conversation

@shanicky

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR attempts to add avg and stddev support for Int256. Because we currently only support conversion from Int256 to float64 (rather than decimal), we use float64 for these calculations.

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
    - [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

@github-actions github-actions Bot added type/feature Type: New feature. user-facing-changes Contains changes that are visible to users labels Apr 17, 2023
@shanicky
shanicky requested a review from wangrunji0408 April 17, 2023 05:05
@shanicky
shanicky marked this pull request as ready for review April 17, 2023 05:06
@shanicky
shanicky requested a review from xiangjinwu April 17, 2023 05:07
@shanicky
shanicky marked this pull request as draft April 17, 2023 05:34
@shanicky
shanicky marked this pull request as ready for review April 17, 2023 06:17
@shanicky
shanicky enabled auto-merge April 17, 2023 06:29
@shanicky
shanicky added this pull request to the merge queue Apr 17, 2023
@codecov

codecov Bot commented Apr 17, 2023 •

Copy link
Copy Markdown

Codecov Report

Merging #9217 (d7f1c9a) into main (ff8de5c) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main    #9217      +/-   ##
==========================================
- Coverage   70.83%   70.83%   -0.01%     
==========================================
  Files        1201     1201              
  Lines      200454   200460       +6     
==========================================
- Hits       141992   141988       -4     
- Misses      58462    58472      +10     
Flag Coverage Δ
rust 70.83% <77.77%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/expr/src/sig/agg.rs 18.69% <0.00%> (-0.36%) ⬇️
src/expr/src/sig/cast.rs 88.37% <100.00%> (+0.27%) ⬆️
src/expr/src/vector_op/arithmetic_op.rs 72.21% <100.00%> (+0.06%) ⬆️
src/expr/src/vector_op/cast.rs 89.07% <100.00%> (+0.01%) ⬆️
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 96.28% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shanicky shanicky linked an issue Apr 17, 2023 that may be closed by this pull request
Merged via the queue into main with commit 1df46d2 Apr 17, 2023
@shanicky
shanicky deleted the peng/num256-agg-2 branch April 17, 2023 07:08
lmatz pushed a commit that referenced this pull request Apr 18, 2023
@bernscode bernscode added the 📖✓ Covered or will be covered in the user docs. label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental type/feature Type: New feature. user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

impl AVG and STDDEV for Int256

4 participants