feat: implement avg and stddev for Int256 by float64 - #9217
Merged
Merged
Conversation
shanicky
marked this pull request as ready for review
April 17, 2023 05:06
shanicky
marked this pull request as draft
April 17, 2023 05:34
shanicky
marked this pull request as ready for review
April 17, 2023 06:17
xiangjinwu
approved these changes
Apr 17, 2023
shanicky
enabled auto-merge
April 17, 2023 06:29
Codecov Report
@@ Coverage Diff @@
## main #9217 +/- ##
==========================================
- Coverage 70.83% 70.83% -0.01%
==========================================
Files 1201 1201
Lines 200454 200460 +6
==========================================
- Hits 141992 141988 -4
- Misses 58462 58472 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2 tasks done
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR attempts to add
avgandstddevsupport forInt256. Because we currently only support conversion fromInt256tofloat64(rather than decimal), we usefloat64for these calculations.Checklist For Contributors
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934)../risedev check(or alias,./risedev c)Checklist For Reviewers
Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note