Skip to content

fix(optimizer): PlanCorrelatedIdFinder should be aware of agg filte… - #8762

Merged
lmatz merged 1 commit into
v0.18.0-rcfrom
lz/v0.18.0-rc
Mar 24, 2023
Merged

lmatz merged 1 commit into
v0.18.0-rcfrom
lz/v0.18.0-rc

Conversation

@lmatz

@lmatz lmatz commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

…r (#8667)

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist For Contributors

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
  • All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

  • I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

  • My PR DOES NOT contain user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@github-actions github-actions Bot added the type/fix Type: Bug fix. Only for pull requests. label Mar 24, 2023
@codecov

codecov Bot commented Mar 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #8762 (7af3410) into v0.18.0-rc (cbd3403) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           v0.18.0-rc    #8762   +/-   ##
===========================================
  Coverage       71.08%   71.09%           
===========================================
  Files            1165     1165           
  Lines          192287   192298   +11     
===========================================
+ Hits           136696   136711   +15     
+ Misses          55591    55587    -4     
Flag Coverage Δ
rust 71.09% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ptimizer/plan_visitor/plan_correlated_id_finder.rs 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lmatz
lmatz merged commit 94a2f34 into v0.18.0-rc Mar 24, 2023
@lmatz
lmatz deleted the lz/v0.18.0-rc branch March 24, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/fix Type: Bug fix. Only for pull requests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants