feat(frontend): support pg_stat_activity and an workaround of pg_cancel_backend/pg_terminate_backend - #7274
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7274 +/- ##
==========================================
- Coverage 73.02% 73.01% -0.02%
==========================================
Files 1066 1066
Lines 170189 170211 +22
==========================================
- Hits 124279 124277 -2
- Misses 45910 45934 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hzxa21
left a comment
There was a problem hiding this comment.
Can we also implement a workaround for pg_backend_pid()?
Usage in superset: https://github.com/apache/superset/blob/5b67e0712d5d3c738abf3281e67755af741c5c01/superset/db_engine_specs/postgres.py#L316
Btw, are the changes in dashboard/proto/gen expected?
Rest LGTM
Sure, added in this PR.
Yes, the changes in dashboard/proto/gen are due to some previously merged PRs that forgot to generate. 🥵 |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
To support superset, implement system table
pg_stat_activityand a workaround ofpg_cancel_backend/pg_terminate_backend.Checklist
./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Introduced a system catalog
pg_stat_activity.Introduced some functions:
Release note
Support system catalog
pg_stat_activity, and some functions like:pg_cancel_backend,pg_terminate_backendandpg_backend_pid.Refer to a related PR or issue link (optional)
A workaround of #6891