feat(connector): add connector remote sink - #6493
Conversation
| /// Endpoint of the connector node | ||
| #[clap(long, default_value = "127.0.0.1:60061")] | ||
| pub connector_source_endpoint: String, | ||
| #[clap(long, env = "CONNECTOR_SOURCE_ENDPOINT")] |
There was a problem hiding this comment.
#6481 is merged, which starts connector node and do e2e testing. After we made this change, we may also have to modify the CI to specify the source endpoint via env var.
There was a problem hiding this comment.
We can also add some e2e testing after this PR.
There was a problem hiding this comment.
We can also add some e2e testing after this PR.
Maybe the next one. This one is large enough.
wenym1
left a comment
There was a problem hiding this comment.
Rest LGTM. Thanks for the great work!
|
suggest changing some naming style in with clause |
70cf257 to
6a62457
Compare
Codecov Report
@@ Coverage Diff @@
## main #6493 +/- ##
==========================================
- Coverage 73.86% 73.81% -0.06%
==========================================
Files 1002 1005 +3
Lines 162583 163271 +688
==========================================
+ Hits 120088 120511 +423
- Misses 42495 42760 +265
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
naming style change now integrated into both sides |
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR adds remote sink to connector.
All remote sink operations are passed to the connector node sink service. Specify a connector sink endpoint (currently default to
localhost:50051) and a supported sink type to conduct the check.Checklist
./risedev check(or alias,./risedev c)Documentation
Types of user-facing changes
For instance, query the following to sink changes to a PG table via JDBC
Currently, both RW and the connector node has a support list to check upon.
jdbcandfileare currently supported.Release note
Refer to a related PR or issue link (optional)