feat: support timestamp with time zone for tumble and hop - #5855
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5855 +/- ##
==========================================
- Coverage 75.09% 74.90% -0.19%
==========================================
Files 920 921 +1
Lines 145144 145708 +564
==========================================
+ Hits 108996 109149 +153
- Misses 36148 36559 +411
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TennyZhuang
approved these changes
Oct 17, 2022
neverchanje
approved these changes
Oct 17, 2022
Merged
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
timestamptz +/- interval-usecs,tumble_startwindow_{start,end}type may betimestamptzortimestampdepending on input time column type.timestamptzChecklist
./risedev check(or alias,./risedev c)Documentation
Types of user-facing changes
Release note
tumbleandhopcan now work on columns of typetimestamp with time zonein addition totimestampanddate. We can now process data in UTC rather than naive datetimes.Refer to a related PR or issue link (optional)
Resolves #5599