Skip to content

feat: support timestamp with time zone for tumble and hop - #5855

Merged
mergify[bot] merged 7 commits into
mainfrom
XJ-tstz-tumble-hop
Oct 17, 2022
Merged

mergify[bot] merged 7 commits into
mainfrom
XJ-tstz-tumble-hop

Conversation

@xiangjinwu

@xiangjinwu xiangjinwu commented Oct 14, 2022 •

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Basic expressions: timestamptz +/- interval-usecs, tumble_start
  • Output window_{start,end} type may be timestamptz or timestamp depending on input time column type.
  • Source JSON parser support of timestamptz

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Types of user-facing changes

  • SQL commands, functions, and operators

Release note

tumble and hop can now work on columns of type timestamp with time zone in addition to timestamp and date. We can now process data in UTC rather than naive datetimes.

Refer to a related PR or issue link (optional)

Resolves #5599

@github-actions github-actions Bot added the type/feature Type: New feature. label Oct 14, 2022
@xiangjinwu
xiangjinwu marked this pull request as ready for review October 14, 2022 08:39
@codecov

codecov Bot commented Oct 14, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #5855 (db9a2b4) into main (0f0e6c5) will decrease coverage by 0.18%.
The diff coverage is 35.66%.

@@            Coverage Diff             @@
##             main    #5855      +/-   ##
==========================================
- Coverage   75.09%   74.90%   -0.19%     
==========================================
  Files         920      921       +1     
  Lines      145144   145708     +564     
==========================================
+ Hits       108996   109149     +153     
- Misses      36148    36559     +411     
Flag Coverage Δ
rust 74.90% <35.66%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/hop_window.rs 69.10% <0.00%> (-0.57%) ⬇️
src/ctl/src/cmd_impl/hummock/compaction_group.rs 0.00% <0.00%> (ø)
src/ctl/src/lib.rs 0.92% <0.00%> (-0.49%) ⬇️
src/expr/src/expr/expr_binary_nonnull.rs 79.25% <0.00%> (-2.22%) ⬇️
src/expr/src/vector_op/arithmetic_op.rs 47.67% <0.00%> (-4.64%) ⬇️
src/frontend/src/lib.rs 40.00% <0.00%> (-3.48%) ⬇️
src/frontend/src/scheduler/plan_fragmenter.rs 84.61% <0.00%> (+0.22%) ⬆️
src/frontend/src/session.rs 37.47% <0.00%> (-0.51%) ⬇️
src/frontend/src/test_utils.rs 87.68% <0.00%> (-0.50%) ⬇️
src/meta/src/rpc/service/hummock_service.rs 3.75% <0.00%> (-0.39%) ⬇️
... and 37 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu xiangjinwu added the user-facing-changes Contains changes that are visible to users label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: support timestampz in tumble and hop

3 participants