feat(frontend): support creating empty arrays - #5402
Merged
Merged
Conversation
2 of 3 tasks
xiangjinwu
commented
Sep 16, 2022
Codecov Report
@@ Coverage Diff @@
## main #5402 +/- ##
==========================================
+ Coverage 73.90% 73.91% +0.01%
==========================================
Files 903 903
Lines 140928 140951 +23
==========================================
+ Hits 104150 104187 +37
+ Misses 36778 36764 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
xiangjinwu
force-pushed
the
pr-4715-empty-array
branch
from
September 19, 2022 05:07
8b8fb55 to
50f8efa
Compare
neverchanje
approved these changes
Sep 20, 2022
lmatz
pushed a commit
that referenced
this pull request
Sep 20, 2022
* support parsing empty lists
* DRY parse_row_expr and parse_token_wrapped_exprs{,_zeroable}
* tests
* e2e
* reject `array[]` unless parent is cast
Co-authored-by: wzzzzd <wzzzzd@proton.me>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
4 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
Supersedes #4715 because it was opened on
wzzzzd:support_empty_listfork rather than this repo.Checklist
./risedev check(or alias,./risedev c)Documentation
Types of user-facing changes
Release note
support creating empty arrays (e.g.
array[]::int[])Refer to a related PR or issue link (optional)
#4612