Skip to content

feat(frontend): support creating empty arrays - #5402

Merged
mergify[bot] merged 6 commits into
mainfrom
pr-4715-empty-array
Sep 20, 2022
Merged

mergify[bot] merged 6 commits into
mainfrom
pr-4715-empty-array

Conversation

@xiangjinwu

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

Supersedes #4715 because it was opened on wzzzzd:support_empty_list fork rather than this repo.

dev=> select array[]::int[];
 ?column? 
----------
 {}
(1 row)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

Types of user-facing changes

  • SQL commands, functions, and operators

Release note

support creating empty arrays (e.g. array[]::int[])

Refer to a related PR or issue link (optional)

#4612

@github-actions github-actions Bot added the type/feature Type: New feature. label Sep 16, 2022
Comment thread e2e_test/batch/types/array_ty.slt.part Outdated
@codecov

codecov Bot commented Sep 16, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #5402 (8ed5ad8) into main (fb1bf13) will increase coverage by 0.01%.
The diff coverage is 97.72%.

@@            Coverage Diff             @@
##             main    #5402      +/-   ##
==========================================
+ Coverage   73.90%   73.91%   +0.01%     
==========================================
  Files         903      903              
  Lines      140928   140951      +23     
==========================================
+ Hits       104150   104187      +37     
+ Misses      36778    36764      -14     
Flag Coverage Δ
rust 73.91% <97.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sqlparser/src/parser.rs 92.94% <90.00%> (+0.19%) ⬆️
src/frontend/src/binder/expr/mod.rs 80.56% <100.00%> (+1.47%) ⬆️
src/frontend/src/binder/expr/value.rs 96.46% <100.00%> (+0.04%) ⬆️
src/sqlparser/src/tokenizer.rs 94.49% <0.00%> (+0.11%) ⬆️
.../src/executor/managed_state/aggregation/extreme.rs 95.52% <0.00%> (+0.13%) ⬆️
src/stream/src/executor/source/source_executor.rs 93.91% <0.00%> (+0.16%) ⬆️
src/frontend/src/expr/type_inference/cast.rs 89.90% <0.00%> (+2.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangjinwu
xiangjinwu marked this pull request as ready for review September 16, 2022 10:57
@xiangjinwu xiangjinwu mentioned this pull request Sep 19, 2022
2 tasks done
@mergify
mergify Bot merged commit 69e468a into main Sep 20, 2022
@mergify
mergify Bot deleted the pr-4715-empty-array branch September 20, 2022 02:53
lmatz pushed a commit that referenced this pull request Sep 20, 2022
* support parsing empty lists

* DRY parse_row_expr and parse_token_wrapped_exprs{,_zeroable}

* tests

* e2e

* reject `array[]` unless parent is cast

Co-authored-by: wzzzzd <wzzzzd@proton.me>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@hengm3467 hengm3467 added the user-facing-changes Contains changes that are visible to users label Sep 30, 2022
@xiangjinwu xiangjinwu mentioned this pull request Aug 1, 2023
4 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants