Skip to content

feat(frontend): support explain trace - #3945

Merged
mergify[bot] merged 7 commits into
mainfrom
dylan/support_explain_trace
Jul 19, 2022
Merged

mergify[bot] merged 7 commits into
mainfrom
dylan/support_explain_trace

Conversation

@chenzl25

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.

What's changed and what's your intention?

As Title. Related issue #3944
support explain [verbose] trace to trace each optimization stage of the optimizer.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.

Types of user-facing changes

Please keep the types that apply to your changes, and remove those that do not apply.

  • SQL commands

Release note

Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.

Refer to a related PR or issue link (optional)

Related issue #3944

@github-actions github-actions Bot added the type/feature Type: New feature. label Jul 18, 2022
@codecov

codecov Bot commented Jul 18, 2022 •

Copy link
Copy Markdown

Codecov Report

Merging #3945 (c34c069) into main (761ec04) will decrease coverage by 0.03%.
The diff coverage is 60.49%.

@@            Coverage Diff             @@
##             main    #3945      +/-   ##
==========================================
- Coverage   73.92%   73.89%   -0.04%     
==========================================
  Files         827      828       +1     
  Lines      116942   117044     +102     
==========================================
+ Hits        86453    86485      +32     
- Misses      30489    30559      +70     
Flag Coverage Δ
rust 73.89% <60.49%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/explain.rs 0.00% <0.00%> (ø)
src/frontend/src/handler/mod.rs 63.15% <0.00%> (-2.06%) ⬇️
...tend/src/optimizer/plan_node/logical_multi_join.rs 80.06% <0.00%> (-4.61%) ⬇️
src/frontend/src/optimizer/rule/project_join.rs 0.00% <ø> (ø)
src/sqlparser/src/keywords.rs 100.00% <ø> (ø)
...c/frontend/src/optimizer/plan_node/logical_join.rs 89.63% <23.07%> (-0.81%) ⬇️
.../frontend/src/optimizer/plan_node/logical_apply.rs 72.64% <28.57%> (-7.15%) ⬇️
...frontend/src/optimizer/plan_node/logical_filter.rs 93.10% <35.29%> (-4.04%) ⬇️
src/frontend/src/session.rs 38.40% <43.75%> (+0.21%) ⬆️
...c/frontend/src/optimizer/plan_node/logical_scan.rs 88.57% <52.94%> (-1.92%) ⬇️
... and 40 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@st1page st1page left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and should we add introduce the explain trace in the planner test?

@chenzl25

Copy link
Copy Markdown
Contributor Author

LGTM, and should we add introduce the explain trace in the planner test?

It's fine, but just too sensitive to the optimizer interior implementation.

@mergify
mergify Bot merged commit ccf5f46 into main Jul 19, 2022
@mergify
mergify Bot deleted the dylan/support_explain_trace branch July 19, 2022 02:39
nasnoisaac pushed a commit to nasnoisaac/risingwave that referenced this pull request Aug 9, 2022
* feat(frontend): support explain trace

* refactor(frontend): refactor explain verbose for logical plan

* refactor(frontend): make LogicalAgg and PhysicalAgg explain format consistent

* fmt

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants