feat(frontend): support explain trace - #3945
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3945 +/- ##
==========================================
- Coverage 73.92% 73.89% -0.04%
==========================================
Files 827 828 +1
Lines 116942 117044 +102
==========================================
+ Hits 86453 86485 +32
- Misses 30489 30559 +70
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
st1page
approved these changes
Jul 18, 2022
st1page
left a comment
Contributor
There was a problem hiding this comment.
LGTM, and should we add introduce the explain trace in the planner test?
Contributor
Author
It's fine, but just too sensitive to the optimizer interior implementation. |
nasnoisaac
pushed a commit
to nasnoisaac/risingwave
that referenced
this pull request
Aug 9, 2022
* feat(frontend): support explain trace * refactor(frontend): refactor explain verbose for logical plan * refactor(frontend): make LogicalAgg and PhysicalAgg explain format consistent * fmt Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the Singularity Data, Inc. Contributor License Agreement.
What's changed and what's your intention?
As Title. Related issue #3944
support
explain [verbose] traceto trace each optimization stage of the optimizer.Checklist
./risedev check(or alias,./risedev c)Documentation
If your pull request contains user-facing changes, please specify the types of the changes, and create a release note. Otherwise, please feel free to remove this section.
Types of user-facing changes
Please keep the types that apply to your changes, and remove those that do not apply.
Release note
Please create a release note for your changes. In the release note, focus on the impact on users, and mention the environment or conditions where the impact may occur.
Refer to a related PR or issue link (optional)
Related issue #3944