feat(streaming): extend CREATE TABLE syntax to support creating append-only table source - #3058
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
license-eye has totally checked 833 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 831 | 1 | 1 | 0 |
Click to see the invalid file list
- src/frontend/test_runner/tests/gen/testcases.rs
…d-only table source
skyzh
reviewed
Jun 8, 2022
skyzh
left a comment
Contributor
There was a problem hiding this comment.
any planner test? see frontend/test_runner/README.md for more information.
StrikeW
force-pushed
the
siyuan/append-only
branch
from
June 8, 2022 06:14
cac4970 to
29d1ab6
Compare
Codecov Report
@@ Coverage Diff @@
## main #3058 +/- ##
==========================================
+ Coverage 73.50% 73.52% +0.01%
==========================================
Files 732 732
Lines 99398 99490 +92
==========================================
+ Hits 73065 73148 +83
- Misses 26333 26342 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
skyzh
approved these changes
Jun 9, 2022
| create table t1 (v1 int, v2 int) with ('appendonly' = true); | ||
| select v1, max(v2) as mx2 from t1 group by v1; | ||
| stream_plan: | | ||
| StreamMaterialize { columns: [v1, agg#0(hidden), mx2], pk_columns: [v1], appendonly: true } |
Contributor
There was a problem hiding this comment.
This derivation is wrong. HashAgg will never produce append-only result. We can fix this later.
Contributor
Author
There was a problem hiding this comment.
Oh. you are right. The output of hash agg may produce update (U-, U+)
fuyufjh
reviewed
Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Refer to a related PR or issue link (optional)
close #2962