Skip to content

fix(meta): clean dropped table change logs and watermarks - #26413

Merged
zwang28 merged 1 commit into
mainfrom
wenym1/resolve-issue-26011
Jul 23, 2026
Merged

zwang28 merged 1 commit into
mainfrom
wenym1/resolve-issue-26011

Conversation

@wenym1

@wenym1 wenym1 commented Jul 23, 2026 •

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Dropping a subscription can mark its table change log for complete garbage
collection. The meta-store deletion path previously represented this operation
with u64::MAX, then cast it to the signed meta-model Epoch type. The cast
produced -1, so the resulting checkpoint_epoch < -1 predicate matched no
rows and left the table's change log permanently orphaned.

This PR:

Validation

  • cargo fmt --check
  • git diff --check main...HEAD
  • CARGO_PROFILE_DEV_DEBUG=0 CARGO_BUILD_JOBS=1 cargo test -p risingwave_hummock_sdk --lib test_apply_version_delta_removes_dropped_table_watermark
  • CARGO_PROFILE_DEV_DEBUG=0 CARGO_BUILD_JOBS=1 cargo clippy --all-targets --all-features

Checklist

  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.

Documentation

No user documentation update is required. The operational impact is covered by
the release note below.

Release note

Dropping subscriptions and watermark-bearing materialized views now cleans up
their associated Hummock change-log and watermark metadata, preventing orphaned
metadata from accumulating in the meta database.

wenym1 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added type/fix Type: Bug fix. Only for pull requests. ci/run-e2e-single-node-tests labels Jul 23, 2026
@wenym1 wenym1 added A-meta Area: Meta node. A-storage Area: Storage. A-watermark user-facing-changes Contains changes that are visible to users 📖‒ Only documented in the release notes. ci/run-integration-test-deterministic-simulation labels Jul 23, 2026
@wenym1
wenym1 requested review from hzxa21 and zwang28 July 23, 2026 09:45
@zwang28
zwang28 enabled auto-merge July 23, 2026 10:09
@zwang28
zwang28 added this pull request to the merge queue Jul 23, 2026
Merged via the queue into main with commit aac93a2 Jul 23, 2026
94 of 95 checks passed
@zwang28
zwang28 deleted the wenym1/resolve-issue-26011 branch July 23, 2026 10:57
@github-actions

Copy link
Copy Markdown
Contributor

✅ Cherry-pick PRs (or issues if encountered conflicts) have been created successfully to all target branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-meta Area: Meta node. A-storage Area: Storage. A-watermark ci/run-e2e-single-node-tests ci/run-integration-test-deterministic-simulation need-cherry-pick-since-release-3.0 type/fix Type: Bug fix. Only for pull requests. user-facing-changes Contains changes that are visible to users 📖‒ Only documented in the release notes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: hummock_table_change_log accumulates orphaned rows permanently after subscription drop, causing meta leader degradation

2 participants