fix(connector): keep CDC LSN metric guards alive - #26301
Merged
Merged
Conversation
hzxa21
marked this pull request as ready for review
July 16, 2026 07:14
zwang28
approved these changes
Jul 16, 2026
Contributor
|
✅ Cherry-pick PRs (or issues if encountered conflicts) have been created successfully to all target branches. |
cyliu0
pushed a commit
that referenced
this pull request
Jul 17, 2026
Lazare
pushed a commit
to Lazare/risingwave
that referenced
this pull request
Jul 21, 2026
…avelabs#26301) (risingwavelabs#26312) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: Zhanxiang (Patrick) Huang <hzxa21@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
Fixes #26300.
CDC source enumerator monitor metrics were using
with_guarded_label_values(...).set(...)inside eachon_tick, so the returned guarded metric was dropped immediately and Prometheus could only see the label series briefly around the 30s refresh tick.This PR stores the guarded gauges on the enumerator so the CDC metric labels stay alive for the source enumerator lifetime, then updates the cached gauges on each tick. It covers:
pg_cdc_upstream_max_lsnpg_cdc_confirmed_flush_lsnChecklist
Documentation
Tests