fix(cdc): restart snapshot read correctly - #26129
Merged
Merged
Conversation
Co-authored-by: risingwave-ci <113648949+risingwave-ci@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Cherry-pick fix(cdc): Restart snapshot read correctly
fix(cdc): restart snapshot read correctly (cherry-pick #26105 to release-3.0)
Jul 2, 2026
zwang28
marked this pull request as ready for review
July 15, 2026 10:06
zwang28
enabled auto-merge
July 15, 2026 10:06
zwang28
approved these changes
Jul 15, 2026
cyliu0
approved these changes
Jul 17, 2026
36 of 73 tasks
4 of 8 tasks
wenym1
pushed a commit
that referenced
this pull request
Jul 26, 2026
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: zwang28 <70626450+zwang28@users.noreply.github.com> Co-authored-by: risingwave-ci <113648949+risingwave-ci@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #26105 onto
release-3.0. Fixes incorrect CDC backfill snapshot restart behavior whenneeds_rebuild_snapshotis set.What's changed and what's your intention?
cdc_backfill.rsshould_bypass_snapshot_stream_patch(rate-limit-to-zero check) insidebackfill_loopso it is re-evaluated on each restart, not once at startup.rate_limit_rpsstate before updating to new value — the bypass flag must reflect whether the previous snapshot stream was ever established.if can_start_new_snapshot→if can_start_new_snapshot || needs_rebuild_snapshot, so a requested rebuild actually stages the barrier and breaks out to restart the snapshot.if needs_rebuild_snapshot { continue 'backfill_loop; }inside the barrier emit path (was dead code after the condition fix above).postgres_schema_check_and_schema_change.sltmood_enum→mood_enum_2(withDROP TYPE IF EXISTSguard) to avoid type name conflicts across parallel test runs.Checklist
Documentation
Release note
Fixed a bug where CDC table backfill would not correctly restart the snapshot read after a rate-limit change or explicit rebuild request, potentially causing data loss or stalled backfill progress during recovery.