Skip to content

feat(iceberg): change iceberg default commit checkpoint interval from 10 to 60 - #23552

Merged
chenzl25 merged 6 commits into
mainfrom
dylan/change_iceberg_default_commit_checkpoint_interval
Oct 23, 2025
Merged

feat(iceberg): change iceberg default commit checkpoint interval from 10 to 60#23552
chenzl25 merged 6 commits into
mainfrom
dylan/change_iceberg_default_commit_checkpoint_interval

Conversation

@chenzl25

@chenzl25 chenzl25 commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Change iceberg default commit checkpoint interval from 10 to 60, since 10 is too small for iceberg workload which could generate lots of snapshots.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@chenzl25
chenzl25 requested review from Li0k, hzxa21, wenym1 and xxhZs October 23, 2025 03:40
@chenzl25 chenzl25 added the user-facing-changes Contains changes that are visible to users label Oct 23, 2025
Li0k
Li0k approved these changes Oct 23, 2025
View reviewed changes

@Li0k Li0k left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix UT

@chenzl25
chenzl25 added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit 06ec463 Oct 23, 2025
34 of 35 checks passed
@chenzl25
chenzl25 deleted the dylan/change_iceberg_default_commit_checkpoint_interval branch October 23, 2025 09:02
@WanYixian WanYixian mentioned this pull request Oct 23, 2025
Closed
Copilot AI mentioned this pull request Dec 5, 2025
Merged
3 tasks done
@ysuhaas ysuhaas mentioned this pull request Dec 18, 2025
Closed
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hzxa21 hzxa21 hzxa21 approved these changes
@Li0k Li0k Li0k approved these changes
@wenym1 wenym1 Awaiting requested review from wenym1
+1 more reviewer
@xxhZs xxhZs xxhZs approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ci/run-e2e-iceberg-tests type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenzl25 @hzxa21 @Li0k @xxhZs