You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, we use public as the default schema for postgres jdbc sink sql. However, some of database like questdb doesn't support schema. I think we can just remove the schema from the dml if users haven't specified.
Checklist
I have written necessary rustdoc comments.
I have added necessary unit tests and integration tests.
I have added test labels as necessary.
I have added fuzzing tests or opened an issue to track them.
My PR contains breaking changes.
My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
My PR contains critical fixes that are necessary to be merged into the latest release.
📝 Telemetry Reminder:
If you're implementing this feature, please consider adding telemetry metrics to track its usage. This helps us understand how the feature is being used and improve it further.
You can find the function report_event of telemetry reporting in the following files. Feel free to ask questions if you need any guidance!
src/frontend/src/telemetry.rs
src/meta/src/telemetry.rs
src/stream/src/telemetry.rs
src/storage/compactor/src/telemetry.rs
Or calling report_event_common (src/common/telemetry_event/src/lib.rs) as if finding it hard to implement.
✨ Thank you for your contribution to RisingWave! ✨
This is an automated comment created by the peaceiris/actions-label-commenter. Responding to the bot or mentioning it won't have any effect.
wonder if it is urgently required by a known customer?
If time allows, it is better to give a 1-version notice in advance before making a breaking change
wonder if it is urgently required by a known customer? If time allows, it is better to give a 1-version notice in advance before making a breaking change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
publicas the default schema for postgres jdbc sink sql. However, some of database like questdb doesn't support schema. I think we can just remove the schema from the dml if users haven't specified.Checklist
Documentation
Release note