feat(sink): support sink rate limit for external sink - #19660
Conversation
|
Hi, there. 📝 Telemetry Reminder:
|
|
quick question: if the sink rate limit makes more data buffered in LogStore? |
If sink decoupled is on, yes. If sink decoupled is off, it will cause backpressure. |
66b212a to
908c638
Compare
e656194 to
e7217ba
Compare
This reverts commit 45e0b1e.
45e0b1e to
a9240fb
Compare
|
These logs are keep repeating. Let me try to fix. |
| paused = self.rate_limit == Some(0); | ||
| tracing::info!("rate limit changed from {:?} to {:?}, paused = {paused}", prev, self.rate_limit); | ||
| } else { | ||
| tracing::warn!("rate limit control channel closed"); |
There was a problem hiding this comment.
Should the log reader exit here? Seems there is no way to restore the rate limit control channel.
There was a problem hiding this comment.
Simulation recovery test passed with bail! here.
There was a problem hiding this comment.
Is it okay that I commit the fix directly in this PR?
Signed-off-by: MrCroxx <mrcroxx@outlook.com>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #16253
Support
SET SINK_RATE_LIMITandALTER SINK ... SET SINK_RATE_LIMITfor external sink. Sink into table is not supported.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
Support session config
SET SINK_RATE_LIMIT to ...andALTER SINK ... SET SINK_RATE_LIMIT to ...for external sink. Sink into table is not supported. See example in rate_limit.slt