feat(connector): add DynamoDB sink - #16670
Conversation
| | ScalarRefImpl::Struct(_) | ||
| | ScalarRefImpl::Jsonb(_)) => AttributeValue::S(string.to_text()), |
There was a problem hiding this comment.
There was a problem hiding this comment.
- I'm not sure, the struct here must be named, since in
create sink? - Does this mean providing an
TimestampHandlingMode-like option forjsonbformat to DynamoDB sink?
There was a problem hiding this comment.
You can consider struct as a list of named key values pairs, right?
struct <
id varchar,
name varchar
>
Map<String, Value> {
"id": "123",
"name": "jinser"
}
There was a problem hiding this comment.
Yes, I think the current implementation is like this
refactor dynamodb sink to use batch_write_item
|
DynamoDB can be deployed locally via docker image: https://docs.aws.amazon.com/amazondynamodb/latest/developerguide/DynamoDBLocal.html |
Should I add it to this PR? Or should I open another PR? |
|
@xiangjinwu @fuyufjh @yuhao-su I've made the changes, please take a review when you have time 😃 |
Both are fine, up to you 😃 |
| async fn write_chunk(&mut self) -> Result<()> { | ||
| if !self.request_items.is_empty() { | ||
| let table = self.table.clone(); | ||
| let req_items = std::mem::take(&mut self.request_items) |
There was a problem hiding this comment.
Is it safe to use take here?
There was a problem hiding this comment.
There seems to be no problem, is there anything to worry about
9a903db to
7e8f23c
Compare
| #[serde(flatten)] | ||
| pub aws_auth_props: AwsAuthProps, |
There was a problem hiding this comment.
does it enable IAM like auth?
Co-authored-by: xxhZs <1060434431@qq.com> Co-authored-by: Xinhao Xu <84456268+xxhZs@users.noreply.github.com>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
1:1 mapping DynamoDB table sink.
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
new sink: