Skip to content

feat(memory): add reserved_memory_bytes opt - #16433

Merged
hzxa21 merged 1 commit into
mainfrom
patrick/memory-config
Apr 24, 2024
Merged

hzxa21 merged 1 commit into
mainfrom
patrick/memory-config

Conversation

@hzxa21

@hzxa21 hzxa21 commented Apr 22, 2024 •

Copy link
Copy Markdown
Collaborator

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Related #16130

Prior to this PR, reserved memory for compute node is hardcoded to 30% * total available memory, which may be too much under certain workload and machine set-up. This PR adds a compute node opt for user to configure the reserved memory bytes explicitly, with the default behavior unchanged.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

reserved_memory_bytes startup opt and RW_RESERVED_MEMORY_BYTES env are introduced for compute node to override the reserved memory configuration.

The default setup remains unchanged, which is compute node using 30% of its total memory as the reserved memory.

@hzxa21
hzxa21 requested review from fuyufjh and lmatz April 22, 2024 07:01
@github-actions github-actions Bot added the type/feature Type: New feature. label Apr 22, 2024

@lmatz lmatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@hzxa21
hzxa21 force-pushed the patrick/memory-config branch from 6b2f0b3 to 2d23a73 Compare April 22, 2024 19:16
@hzxa21 hzxa21 changed the title feat(memory): add reserved_mmemory_bytes opt feat(memory): add reserved_memory_bytes opt Apr 23, 2024
@hzxa21 hzxa21 added the user-facing-changes Contains changes that are visible to users label Apr 23, 2024
@hzxa21
hzxa21 added this pull request to the merge queue Apr 24, 2024
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 24, 2024
@hzxa21
hzxa21 added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit dd57b28 Apr 24, 2024
@hzxa21
hzxa21 deleted the patrick/memory-config branch April 24, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/feature Type: New feature. user-facing-changes Contains changes that are visible to users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants