feat: add optional created_at and initialized_at for rw relations - #11199
Merged
Merged
Conversation
shanicky
force-pushed
the
peng/created_at
branch
3 times, most recently
from
July 25, 2023 08:49
d1d2523 to
038591a
Compare
shanicky
marked this pull request as ready for review
July 25, 2023 09:40
yezizp2012
reviewed
Jul 25, 2023
yezizp2012
left a comment
Contributor
There was a problem hiding this comment.
Rest LGTM! Thx for the great job, it will be very helpful for debugging in rw.
Codecov Report
@@ Coverage Diff @@
## main #11199 +/- ##
==========================================
- Coverage 69.68% 69.66% -0.02%
==========================================
Files 1351 1351
Lines 224437 224531 +94
==========================================
+ Hits 156392 156417 +25
- Misses 68045 68114 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
created_at and started_at for rw relationscreated_at and initialized_at for rw relations
shanicky
force-pushed
the
peng/created_at
branch
2 times, most recently
from
July 25, 2023 10:59
4cb4024 to
5c51584
Compare
…me` & `read_meta_snapshot` methods Add optional timestamps to Table message and remove created_at_epoch field. Remove import std::time::Duration in no_shuffle_backfill.rs Add optional fields `started_at_epoch` and `created_at_epoch` in multiple files and structs. Add optional fields to Sink message, SinkDesc, SinkCatalog and set created_at_epoch time feat: Add optional fields to Source message Replace 'started_at_epoch' with 'initialized_at_epoch' in multiple message definitions and struct fields.
shanicky
force-pushed
the
peng/created_at
branch
from
July 25, 2023 12:12
5c51584 to
75cb3b7
Compare
yezizp2012
approved these changes
Jul 25, 2023
shanicky
enabled auto-merge
July 25, 2023 12:28
Contributor
Author
|
cc @neverchanje |
1 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation