fix(browser-sdk,react-sdk): remove featureId option for requestFeedback #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- standardize on `features` for passing a feaure list - take arguments from the old `features` options and put them in at the root options map.
Base automatically changed from
browser-react-3.0.alpha-cleanup-init-opts
to
browser-react-3.0.alpha
February 6, 2025 12:46
5ce13f3 to
6f3f745
Compare
…eature-key-feedback
….com:bucketco/bucket-javascript-sdk into browser-react-3.0.alpha-feature-key-feedback
pavkam
reviewed
Feb 10, 2025
Contributor
pavkam
left a comment
There was a problem hiding this comment.
Just a reminder: This will be a breaking change. Maybe get rid of all deprecated fields in this PR so we don't have to make more of them?
Contributor
Author
|
I removed deprecated options related to feedback. I didn't find any other deprecated options in the browser/react SDKs. |
pavkam
approved these changes
Feb 12, 2025
…eature-key-feedback
….com:bucketco/bucket-javascript-sdk into browser-react-3.0.alpha-feature-key-feedback
…eature-key-feedback
roncohen
added a commit
that referenced
this pull request
Feb 26, 2025
…ck (#309) Remove legacy `featureId` option when using the `requestFeedback` and `feedback` methods The actual feedback payload can still contain the featureId because bucket's prompting message do not include the feature key.
roncohen
added a commit
that referenced
this pull request
Feb 26, 2025
…ck (#309) Remove legacy `featureId` option when using the `requestFeedback` and `feedback` methods The actual feedback payload can still contain the featureId because bucket's prompting message do not include the feature key.
roncohen
added a commit
that referenced
this pull request
Feb 26, 2025
…ck (#309) Remove legacy `featureId` option when using the `requestFeedback` and `feedback` methods The actual feedback payload can still contain the featureId because bucket's prompting message do not include the feature key.
roncohen
added a commit
that referenced
this pull request
Feb 26, 2025
…ck (#309) Remove legacy `featureId` option when using the `requestFeedback` and `feedback` methods The actual feedback payload can still contain the featureId because bucket's prompting message do not include the feature key.
roncohen
added a commit
that referenced
this pull request
Feb 26, 2025
…ck (#309) Remove legacy `featureId` option when using the `requestFeedback` and `feedback` methods The actual feedback payload can still contain the featureId because bucket's prompting message do not include the feature key.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove legacy
featureIdoption when using therequestFeedbackandfeedbackmethodsThe actual feedback payload can still contain the featureId because bucket's prompting message do not include the feature key.