[PHP 8.0] Add ChangeSwitchToMatchRector

[TomasVotruba]

Covers nikic/PHP-Parser#672, https://wiki.php.net/rfc/match_expression_v2

 class SomeClass
 {
     public function run()
     {
-        $statement = switch ($this->lexer->lookahead['type']) {
-            case Lexer::T_SELECT:
-                $statement = $this->SelectStatement();
-                break;
-            default:
-                $this->syntaxError('SELECT, UPDATE or DELETE');
-                break;
-        }
+        $statement = match ($this->lexer->lookahead['type']) {
+            Lexer::T_SELECT => $this->SelectStatement(),
+            default => $this->syntaxError('SELECT, UPDATE or DELETE'),
+        };
     }
 }

Ref #3127

[TomasVotruba]

@ondrejmirtes Hi Ondra, here is the failing CI job I made just for this issue:
https://github.com/rectorphp/rector/pull/3569/checks?check_run_id=928156765

Only running bin/rector causes it.

[TomasVotruba]

I've just added separated jobs for:

• php-parser 4.6 - works - https://github.com/rectorphp/rector/pull/3569/checks?check_run_id=928191149
• php-parser 4.7 - breaks - https://github.com/rectorphp/rector/pull/3569/checks?check_run_id=928191237

Everything else in the code is the same

[ondrejmirtes]

I probably know what this is about:

• Here's the phpstan/phpstan autoloader: https://github.com/phpstan/phpstan/blob/master/bootstrap.php
• It's used when you use phpstan/phpstan but use PHPStan not by running vendor/phpstan/phpstan/phpstan executable but by asking for some internal classes, like NodeScopeResolver or RuleTestCase.
• At some point this line will be executed:

$composerAutoloader = require 'phar://' . __DIR__ . '/phpstan.phar/vendor/autoload.php';

• Which means that potentially the PHP-Parser library from inside the PHAR will be loaded some time later.
• But it has to be this way as PHPStan internals also rely on PHP-Parser.
• My conclusion is that if a project uses PHPStan internals but also requires PHP-Parser on its own, the PHP-Parser has to be the same version as it's bundled in the PHPStan's PHAR.

I really don't know the way out of this, it's a hard problem.

[TomasVotruba]

Great! I came to exact same conclussion.

[TomasVotruba]

The only solution that worked for me in the past is to use the same php-parser as PHPStan does.
Last bug was with property promotion, so we had to wait till new version of phpstan uses 4.6. It does now, but there is already 4.7 with more breaks.

[ondrejmirtes]

I'll be releasing PHPStan 0.12.34 with PHP-Parser 4.7 later today 🚀

[TomasVotruba]

That's way over my expectations. Epic, thank you 👏 ❤️

[TomasVotruba]

@ondrejmirtes I've just updated Rector and can confirm 0.12.34 works purfectly! Thanks 👏 👏

[ondrejmirtes]

Cool :)