[Experiment][Printer] Move AlwaysRememberedExpr tweak logic to separate service after a Match_ found #7654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter a Match_ found
Member
Author
|
All checks have passed 🎉 @TomasVotruba I think it is ready :) |
Member
Author
|
For reference, if it merged, this need to be tested in reported getrector.com/demo page below back in 2024: That can't be reproduced by unit test, but was only fixable via patch on BetterStandardPrinter. see referenced PRs:
It will needs some people to test on original/related issue with it. |
Member
|
Looks good, lets give this a go 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to move away
AlwaysRememberedExprtweak fromPrinterto separate service after processing\PHPStan\Analyser\NodeScopeResolver::processNodes()calls.Twis was requires 2 locations which not fully patch, then move to printer, this time apply full patch with verify both
AlwaysRememberedExprandorigNodeitself aMatch_, but move out from the Printer.There was an issue that only reproduced via https://getrector.com/demo/ , so this requires verification after merged.