Skip to content

Conversation

@TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Oct 25, 2025

By conventions, comments must be before doctrine annotations. All other nodes work this way: php-parser does not allow // commments after the node. This should also speedup docblock parsing.

Reverts #5650

@TomasVotruba TomasVotruba marked this pull request as draft October 25, 2025 20:21
@TomasVotruba TomasVotruba marked this pull request as ready for review October 25, 2025 20:29
@TomasVotruba TomasVotruba changed the title remove attribute comments support as comments require standalone line before any doctrine annotation [comments] Remove attribute comments support as comments require standalone line before any doctrine annotation Oct 25, 2025
@TomasVotruba TomasVotruba merged commit 926706f into main Oct 25, 2025
60 of 61 checks passed
@TomasVotruba TomasVotruba deleted the tv-cleanup-comments branch October 25, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants