[Application] Move autoload and paths setup to ApplicationFileProcessor

[samsonasik]

@marcelthole @boesing while working on alternative PR for EnumCaseToPascalCaseRector:

• [Alternative] Add EnumCaseToPascalCaseRector with use of DynamicSourceLocatorProvider #6899

I realized that when autoload provided, on parallel, the registered autoload input setup gone on parallel. This PR ensure it always included, as on parallel, that means it separate process.

• to avoid setup autoload via -a gone on parallel because of separate process.
• ensure the check of

rector-src/src/Console/Command/ProcessCommand.php

Line 120 in b29132b

if ($this->dynamicSourceLocatorDecorator->arePathsEmpty()) {

only check registered paths via withPaths() or path provided by command, not include autoloadPaths() because of no paths defined, but defined withPaths() is empty, it never empty:

->withPaths([]) // empty, should STOP, but because we have autoload paths defined
->withAutoloadPaths([__DIR__  . '/../some/file.php']);

and below added too early:

⇓

rector-src/src/Console/Command/ProcessCommand.php

Line 99 in b29132b

$this->additionalAutoloader->autoloadPaths();

it make never empty.

---

Last but not least:

I am thinking of discussing the usage of autoloadPaths() more properly, since it currently mix between "autoload" or "include files provided to be analyzed".

rector-src/src/Autoloading/AdditionalAutoloader.php

Lines 40 to 44 in b29132b

	public function autoloadPaths(): void
	{
	$autoloadPaths = SimpleParameterProvider::provideArrayParameter(Option::AUTOLOAD_PATHS);
	$this->dynamicSourceLocatorDecorator->addPaths($autoloadPaths);
	}

but that's different PR to discuss to keep match with current documentation

https://getrector.com/documentation/static-reflection-and-autoload#content-register

[samsonasik]

All checks have passed 🎉 @TomasVotruba it is ready for review.

/cc @staabm would be great if you can review as well :), thank you.

[samsonasik]

Ok, it seems there is autoloadFromCommandLine() in bin/rector.php

https://github.com/rectorphp/rector-src/blob/b29132bd65fd8b5adb7226daedc9d22e5214595b/bin/rector.php#L74C21-L96

which seems mixed it.

Closing for now.

[github-actions]

This pull request has been automatically locked because it has been closed for 150 days. Please open a new PR if you want to continue the work.