Repository navigation
feat: expose typed handoff reasoning effort - #138
Open
Will-Liang329 wants to merge 2 commits into
Open
Will-Liang329 wants to merge 2 commits into
Will-Liang329 wants to merge 2 commits into
Conversation
rebel0789
requested changes
Oct 1, 2026
rebel0789
left a comment
Owner
There was a problem hiding this comment.
The implementation and complete local smoke suite pass, but one public contract is currently inaccurate: the reasoning_effort schema says the local executor validates provider support, while this PR only serializes opaque metadata and execute-handoff does not parse, apply, or validate it. Please either change that description to say it is metadata that CodexPro does not validate/apply, matching the PR body, or implement the claimed executor behavior. After #141 lands, please also update the branch so the patched dependency audit and Windows matrix can run cleanly.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds optional
reasoning_effortto the typedhandoff_to_agentMCP input and serializes it asReasoning effort: <value>in the existing deterministic handoff preamble.The value is opaque metadata: CodexPro does not apply provider-specific effort validation or execute a provider. When omitted, the generated handoff retains its existing format and behavior. This supports downstream runner/router contracts without introducing an AHR dependency.
Validation:
npm run buildand the completenpm run smokesuite. The smoke test checkstools/listexposes the optional string field, verifies the serialized preamble, and verifies omission compatibility.