Repository navigation
fix: avoid buffering full diff for stats-only git_diff - #117
Open
Stephenxu000 wants to merge 1 commit into
Open
Stephenxu000 wants to merge 1 commit into
Stephenxu000 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
git_diff(include_diff=false)is documented as a stats-only path, but it still materializes the full unified diff before discarding it. Large diffs can therefore exceed the Git child-process output buffer and returnspawnSync git ENOBUFSeven when raw diff output was explicitly disabled.Fix
git diff --numstatfor the stats-only path instead of generating the unified diff.include_diff=true.Regression coverage
The smoke test creates an isolated Git repository with a diff larger than a 4 KB
CODEXPRO_MAX_OUTPUT_BYTESlimit. The test fails on the current upstream implementation withspawnSync git ENOBUFSand passes with this change while reporting the expected+600 / -600stats and an empty raw diff.Verification
npm run buildnpm run smokegit diff --checkSecurity impact: none expected. This remains a read-only Git operation and keeps the existing path guard and
--no-ext-diff/--no-textconvrestrictions.