fix PR #13185: json bool operator now same as json_ref#13192
Merged
maloel merged 1 commit intorealsenseai:developmentfrom Jul 25, 2024
Merged
fix PR #13185: json bool operator now same as json_ref#13192maloel merged 1 commit intorealsenseai:developmentfrom
maloel merged 1 commit intorealsenseai:developmentfrom
Conversation
OhadMeir
approved these changes
Jul 25, 2024
maloel
added a commit
to maloel/librealsense
that referenced
this pull request
Jul 29, 2024
maloel
added a commit
that referenced
this pull request
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Innocent-looking code like this (from PR #13185):
does an implicit bool conversion.
This is implemented in
json_refasexists()while the default json implementation uses an implicit templated conversion. The logic is different.We decided to align the operator bool logic so they both behave the same: both check for existence rather than doing a conversion. It is preferable to never use implicit conversions!