Conversation
OhadMeir
reviewed
Feb 20, 2024
| // License: Apache 2.0. See LICENSE file in root directory. | ||
| // Copyright(c) 2023 Intel Corporation. All Rights Reserved. | ||
|
|
||
| module udds |
Contributor
There was a problem hiding this comment.
What is udds? For other topics we used raw namespace.
Contributor
Author
There was a problem hiding this comment.
It's the topic they had built in. We can talk about it.
OhadMeir
reviewed
Feb 20, 2024
| { | ||
| // For SW-only devices, allow some time for DDS devices to connect | ||
| int tries = 3; | ||
| std::cout << "No device detected. Waiting..." << std::flush; |
Contributor
There was a problem hiding this comment.
Some devices can already be detected. "Waiting for remote devices" might be better
OhadMeir
reviewed
Feb 20, 2024
OhadMeir
reviewed
Feb 20, 2024
OhadMeir
approved these changes
Feb 25, 2024
Contributor
OhadMeir
left a comment
There was a problem hiding this comment.
Approved, waiting next PRs that will handle the comments and also validate updating FW using the viewer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support for DFU on DDS
Details:
operator<()forrs2::deviceto use the fw-update-id (didn't work on recovery devices)rs2_check_firmware_compatibilitynow works on either recovery or non-recovery devicesStill not done!