ThroughStream is now a direct implementation of DuplexStreamInterface #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It no longer builds on top of CompositeStream, which helps cleaning up the class hierarchy and removes unneeed readable and writable objects.
jsor
approved these changes
Apr 24, 2017
WyriHaximus
approved these changes
Apr 24, 2017
This was referenced Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It no longer builds on top of CompositeStream, which helps cleaning up
the class hierarchy and removes unneeed readable and writable objects.
This is technically a BC break because it changes the class hierarchy, but outside behavior is actually unchanged. Any of the known implementations (http://packanalyst.com/class?q=React%5CStream%5CThroughStream) would not be affected by this change.