Remove custom full-drain event #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ping @reactphp/core, this targets the upcoming v0.5.0 milestone |
jsor
approved these changes
Mar 3, 2017
WyriHaximus
approved these changes
Mar 3, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
full-drainevent from theBufferand instead close as appropriate internally. This event is currently only used toend()the buffer. This does not change any of the outside behavior otherwise.While not used anywhere in React's ecosystem, this is still a BC break because others may actually rely on this event. However, this event has never been documented anyway, so chances are nobody will be affected by this BC break.