Handle \Throwable in the same way as \Exception

[joshdifabio]

This is a backwards-compatible change which enables react/promise to handle PHP7's \Throwable in the same way it handles PHP5's \Exception.

I'd really love to get this merged asap as it's a trivial change which is backwards compatible and \Errors are currently causing instability in a production app which we've got running on PHP7.

[jsor]

LGTM /ping @WyriHaximus @cboden @clue

[cboden]

LGTM

fixes #49

[WyriHaximus]

Does it matter for PHP 5 that Throwable comes before Exception? Except from that LGTM

[jsor]

@WyriHaximus i can't think of any reason (and tests pass).

[WyriHaximus]

@jsor fair point, was just wondering :)

[jsor]

Thanks @joshdifabio, released in v2.3.0.

[joshdifabio]

Brilliant, thanks for moving so quickly on this.
On 24 Mar 2016 9:23 p.m., "Jan Sorgalla" [email protected] wrote:

Thanks @joshdifabio https://github.com/joshdifabio, released in v2.3.0
https://github.com/reactphp/promise/releases/tag/v2.3.0.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#51 (comment)