Change parser to use single regular expression to match all headers #350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelunik
reviewed
Sep 26, 2019
WyriHaximus
requested changes
Sep 27, 2019
jsor
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset was originally worked on in preparation for upcoming refactorings to rearrange some unrelated logic inside the request parser class to prepare for persistent HTTP connections in follow-up PR. This changeset does not affect the public API and happens to improve performance noticeably from around 9500 req/s to 11000 req/s on my machine (best of 5).
Builds on top of #349
Resolves #302, thanks @kelunik for bringing this up!