Documentation improvement #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
approved these changes
Mar 23, 2018
WyriHaximus
approved these changes
Mar 23, 2018
jsor
reviewed
Mar 23, 2018
README.md
Outdated
| Similarly, you can use the result of the `$next` middleware request handler | ||
| function to modify the outgoing response. | ||
| Note that as per the above documentation, the `$next` function may return a | ||
| Note that as per the above documentation, the `$next` may return a |
Member
There was a problem hiding this comment.
"...the $next may return a..." reads a bit odd imho.
Contributor
Author
There was a problem hiding this comment.
May be "the $next variable" or "the callable $next"?
Member
There was a problem hiding this comment.
In the other paragraph ↓, its called "$next middleware request handler", maybe that?
Remove word `function` from middleware description
e0e8313 to
80fa528
Compare
jsor
approved these changes
Mar 23, 2018
WyriHaximus
approved these changes
Mar 23, 2018
clue
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the same as #297
Removes word
functionfrom middleware description.