-
-
Notifications
You must be signed in to change notification settings - Fork 167
Note about PSR-15 middleware #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
README.md
Outdated
|
|
||
| #### PSR-15 Middleware | ||
|
|
||
| Additionally we support PSR-15 through the [Friends of ReactPHP](https://github.com/friends-of-reactphp) [PSR-15 middleware adapter](https://github.com/friends-of-reactphp/http-middleware-psr15-adapter). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove "Additionally" as the reference to the previous section isn't required and probably confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsor Good one, updated the PR
clue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these changes makes perfect sense 👍
However, looking at the bigger picture, I feel that this is currently incomplete. PSR-15 implements two interfaces, we should probably explicitly list both and how we can or can't work with them.
Also, the #Middleware chapter mentions "ongoing effort", should we update this paragraph?
|
@clue makes sense, I'll add a bit about why we don't support it directly in |
|
@clue reworded the PSR-15 paragraph and the Middleware chapter where it mentions the |
With the acceptance of PSR-15 we should add a note that we support for it through the FoR adapter