Skip to content

Conversation

@WyriHaximus
Copy link
Member

With the acceptance of PSR-15 we should add a note that we support for it through the FoR adapter

README.md Outdated

#### PSR-15 Middleware

Additionally we support PSR-15 through the [Friends of ReactPHP](https://github.com/friends-of-reactphp) [PSR-15 middleware adapter](https://github.com/friends-of-reactphp/http-middleware-psr15-adapter).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd remove "Additionally" as the reference to the previous section isn't required and probably confusing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsor Good one, updated the PR

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes makes perfect sense 👍

However, looking at the bigger picture, I feel that this is currently incomplete. PSR-15 implements two interfaces, we should probably explicitly list both and how we can or can't work with them.

Also, the #Middleware chapter mentions "ongoing effort", should we update this paragraph?

@WyriHaximus
Copy link
Member Author

@clue makes sense, I'll add a bit about why we don't support it directly in react/http 👍 . (The answer is really simple though, return types.)

@WyriHaximus
Copy link
Member Author

@clue reworded the PSR-15 paragraph and the Middleware chapter where it mentions the ongoing effort

@clue clue removed this from the v0.8.2 milestone Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants