Skip to content

Conversation

@clue
Copy link
Member

@clue clue commented Nov 21, 2017

The current maximum request header size is rather small and can easily be reached by using long URIs or long cookie values. This simple PR raises the default maximum request header size from 4k to 8k to match other common implementations, such as Apache, nginx etc. (https://stackoverflow.com/questions/686217/maximum-on-http-header-values or http://nginx.org/en/docs/http/ngx_http_core_module.html#large_client_header_buffers).

This is currently a hard-coded default with no way to change this value as a consumer. There's another open issue #214 to give users more control over this. This PR is created in the hope to spare users from looking into this in the first place.

@clue clue added this to the v0.8.0 milestone Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants