Skip to content

Add test for uncommon middleware array formats #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clue merged 1 commit into from
Nov 17, 2017
Merged

Add test for uncommon middleware array formats #247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 140 additions & 0 deletions tests/MiddlewareRunnerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,4 +193,144 @@ function (ServerRequestInterface $request, $next) use (&$receivedRequests) {
$receivedRequests
);
}

public function provideUncommonMiddlewareArrayFormats()
{
return array(
array(
function () {
$sequence = '';

// Numeric index gap
return array(
0 => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'A';

return $next($request);
},
2 => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'B';

return $next($request);
},
3 => function () use (&$sequence) {
return new Response(200, array(), $sequence . 'C');
},
);
},
'ABC',
),
array(
function () {
$sequence = '';

// Reversed numeric indexes
return array(
2 => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'A';

return $next($request);
},
1 => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'B';

return $next($request);
},
0 => function () use (&$sequence) {
return new Response(200, array(), $sequence . 'C');
},
);
},
'ABC',
),
array(
function () {
$sequence = '';

// Associative array
return array(
'middleware1' => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'A';

return $next($request);
},
'middleware2' => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'B';

return $next($request);
},
'middleware3' => function () use (&$sequence) {
return new Response(200, array(), $sequence . 'C');
},
);
},
'ABC',
),
array(
function () {
$sequence = '';

// Associative array with empty or trimmable string keys
return array(
'' => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'A';

return $next($request);
},
' ' => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'B';

return $next($request);
},
' ' => function () use (&$sequence) {
return new Response(200, array(), $sequence . 'C');
},
);
},
'ABC',
),
array(
function () {
$sequence = '';

// Mixed array keys
return array(
'' => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'A';

return $next($request);
},
0 => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'B';

return $next($request);
},
'foo' => function (ServerRequestInterface $request, $next) use (&$sequence) {
$sequence .= 'C';

return $next($request);
},
2 => function () use (&$sequence) {
return new Response(200, array(), $sequence . 'D');
},
);
},
'ABCD',
),
);
}

/**
* @dataProvider provideUncommonMiddlewareArrayFormats
*/
public function testUncommonMiddlewareArrayFormats($middlewareFactory, $expectedSequence)
{
$request = new ServerRequest('GET', 'https://example.com/');
$middlewareStack = new MiddlewareRunner($middlewareFactory());

/** @var ResponseInterface $response */
$response = Block\await($middlewareStack($request), Factory::create());

$this->assertSame($expectedSequence, (string) $response->getBody());
}
}