Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 29 additions & 9 deletions tests/MiddlewareRunnerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
use React\EventLoop\Factory;
use React\Http\MiddlewareRunner;
use React\Http\ServerRequest;
use React\Promise;
use React\Tests\Http\Middleware\ProcessStack;
use RingCentral\Psr7\Response;
use Clue\React\Block;
Expand Down Expand Up @@ -93,7 +94,26 @@ public function testProcessStack(array $middlewares, $expectedCallCount)
}
}

public function testNextCanBeRunMoreThanOnceWithoutCorruptingTheMiddlewareStack()
public function provideErrorHandler()
{
return array(
array(
function (\Exception $e) {
throw $e;
}
),
array(
function (\Exception $e) {
return Promise\reject($e);
}
)
);
}

/**
* @dataProvider provideErrorHandler
*/
public function testNextCanBeRunMoreThanOnceWithoutCorruptingTheMiddlewareStack($errorHandler)
{
$exception = new \RuntimeException('exception');
$retryCalled = 0;
Expand All @@ -110,15 +130,15 @@ public function testNextCanBeRunMoreThanOnceWithoutCorruptingTheMiddlewareStack(
$response = new Response();
$called = 0;
$runner = new MiddlewareRunner(array(
$retry,
function () use (&$called, $response, $exception) {
$called++;
if ($called === 1) {
throw $exception;
$retry,
function () use ($errorHandler, &$called, $response, $exception) {
$called++;
if ($called === 1) {
return $errorHandler($exception);
}

return $response;
}

return $response;
}
));

$request = new ServerRequest('GET', 'https://example.com/');
Expand Down