Add MiddlewareRunner test ensuring multiple runs always invoke all middleware #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
reviewed
Oct 12, 2017
tests/TestCase.php
Outdated
| } | ||
|
|
||
| return $mock; | ||
| } |
Member
There was a problem hiding this comment.
How would we test this method? 😋
On a more serious note, this looks really complicated for such a simple test. As an alternative, maybe keep a counter somewhere and explicitly call the handler twice?
Member
Author
There was a problem hiding this comment.
This is a copy of the expectCallableConsecutive() from above with additional $mock->willReturnCallback() ;)
As an alternative, maybe keep a counter somewhere and explicitly call the handler twice?
Not sure what you mean here? Could you elaborate?
Member
Author
There was a problem hiding this comment.
@clue I've updated the test and removed the test helper.
…ddleware in correct order
7fbc299 to
6c846ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #236 (comment)