Trim leading zeros of chunk headers in ChunkedDecoder #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clue
approved these changes
Mar 1, 2017
Member
clue
left a comment
There was a problem hiding this comment.
Nice! Also thanks for the background links! 👍
WyriHaximus
approved these changes
Mar 1, 2017
jsor
approved these changes
Mar 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @maciejmrozinski that found this behavior in the http-client(link to PR).
According to https://tools.ietf.org/html/rfc7230#section-4.1
leading zeros are allowed as value for the header of each chunk.
So e.g.
000500aband000000are valid values.Currently this will lead to an error event, because
hexdecanddechexwill remove the leading zeros, so the assertion will fail. This PR takes care of this problem and will allow leading zeros.