Skip to content

Conversation

@nhedger
Copy link
Contributor

@nhedger nhedger commented Jun 20, 2022

See reactphp/http#458

Reopened because I messed #50

Copy link
Member

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nhedger Thanks for the the quick update, changes LGTM! 👍

Reopened because I messed #50

Looks like the original PR could have been reopened and force-pushed to again. We usually try to avoid filing new PRs in these instances to avoid unneeded email notifications, but I guess it's now easier to stick with this new PR.

@clue clue added this to the v1.2.0 milestone Jun 20, 2022
@clue clue requested a review from WyriHaximus June 20, 2022 15:07
@nhedger
Copy link
Contributor Author

nhedger commented Jun 20, 2022

Couldn't find a way to reopen, possibly because I don't have the rights to. I'll ask your next time this arises.

@WyriHaximus WyriHaximus merged commit 161426e into reactphp:1.x Jun 24, 2022
@nhedger nhedger deleted the chore/remove-dollar-sign branch June 24, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants