Skip to content

Conversation

@WyriHaximus
Copy link
Member

No description provided.

…lve process and go straight to the global function
@clue clue added this to the v0.5.1 milestone Oct 4, 2018
@clue clue merged commit 7c6d7f3 into reactphp:master Oct 4, 2018
@clue clue modified the milestones: v0.5.1, v0.6.0 Jan 11, 2019
@nicolas-grekas
Copy link

For the record: except for a limited list of special functions, adding a leading \ to function calls provides no measurable benefit. There is zero performance improvement from these. Since this worsen readibility, I'm on the side this is undesired. (just saying; my opinion has no importance here :) )

@WyriHaximus
Copy link
Member Author

@nicolas-grekas In the long term I'd prefer to go with use function abc; over \abc(); for readability. Thank you for that list I was unaware of that. There are some situations where we did gain a significant performance gain from doing this so I'll investigate that.

P.S. As far as I'm concerned everyone's opinion is considered and kept in mind. But we can't guarantee we agree or act on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants