Skip to content

Conversation

@clue
Copy link
Member

@clue clue commented Jun 8, 2018

This simple PR renames the existing remove() method to delete() for consistency with PSR-6 and PSR-16. It also adds some documentation to be in line with #16 and #29, but the behavior is otherwise left unchanged.

// old
$cache->remove('foo');

// new
$cache->delete('foo');

Empirical evidence suggests that this method is rarely used and this release includes a number of BC breaks that aim at making this interface act more like a standard PSR-16 cache, so I figured it makes sense to rename this as part of this release.

@clue clue added this to the v0.5.0 milestone Jun 8, 2018
@clue
Copy link
Member Author

clue commented Jun 8, 2018

@jsor Good catch, updated! :shipit:

@clue
Copy link
Member Author

clue commented Jun 8, 2018

Rebased on master to resolve merge conflict now that #29 is in :shipit:

@WyriHaximus WyriHaximus merged commit 834c1bd into reactphp:master Jun 8, 2018
@clue clue deleted the delete branch June 8, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants