feat: support classNames and styles #928

thinkasany · 2025-03-16T03:26:50Z

Summary by CodeRabbit

新功能
- 树组件现支持自定义样式与类名，允许用户为图标、项和标题分别指定样式。此增强提升了组件的灵活性，使其更易于与整体设计风格和视觉需求匹配。
测试
- 在树组件的测试套件中新增了测试用例，以验证自定义类名和样式的支持。

vercel · 2025-03-16T03:26:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
tree	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 17, 2025 7:15am

coderabbitai · 2025-03-16T03:26:57Z

Walkthrough

该 PR 在 Tree 组件体系中引入了语义化样式与类名支持。新定义了 SemanticName 类型，并更新了 TreeProps 与 TreeContextProps 接口，添加了 styles 与 classNames 两个可选属性用于映射样式和类名。TreeNode 组件相应调整以从上下文中读取并应用这些新属性，同时新增单元测试验证这些变更。

Changes

文件	更改摘要
`src/Tree.tsx`	新增 `SemanticName` 类型定义；在 `TreeProps` 接口中增加了可选的 `styles` 和 `classNames` 属性；更新上下文提供的值。
`src/TreeNode.tsx`	从上下文中提取 `styles` 和 `classNames`；条件性应用于图标、标题和容器的样式、类名。
`src/contextTypes.ts`	导入 `SemanticName` 类型；在 `TreeContextProps` 接口中加入 `styles` 和 `classNames` 属性。
`tests/Tree.spec.tsx`	添加新测试用例，验证 Tree 组件对自定义样式和类名的支持。

Sequence Diagram(s)

sequenceDiagram
    participant T as Tree Component
    participant TP as TreeContext.Provider
    participant N as TreeNode Component
    T->>TP: 提供 styles 与 classNames
    TP->>N: 分发更新后的上下文
    N->>N: 应用 context 中的样式和类名

Possibly related PRs

chore: code optimization #906: 涉及 Tree 组件与上下文接口的修改，与当前 PR 在 props 和 context 管理上有直接关联。
fix: fix renderSwitcher issue #910: 涉及 TreeProps 接口的修改，增加了新属性以增强功能，与当前 PR 直接相关。
chore: add process.env.NODE_ENV #903: 涉及 TreeNode 组件的更新，增强了其样式能力，与当前 PR 的 TreeNode 调整密切相关。

Suggested reviewers

zombieJ
afc163

Poem

我是一只敏捷的小兔，代码跳跃不停步，
新增语义让组件更出彩，样式与类名随心入。
Tree 的每个节点都闪亮，
树形结构乐章奏响天际，
小兔祝福大家代码无忧愁！
🐰✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/Tree.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-react".

(The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react@latest --save-dev

The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs [email protected]_jest@29.7.0_@types [email protected][email protected]/node_modules/@umijs/fabric/dist/eslint.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

tests/Tree.spec.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-react".

(The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react@latest --save-dev

The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs [email protected]_jest@29.7.0_@types [email protected][email protected]/node_modules/@umijs/fabric/dist/eslint.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

src/TreeNode.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-react".

(The package "eslint-plugin-react" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-react@latest --save-dev

The plugin "eslint-plugin-react" was referenced from the config file in ".eslintrc.js » /node_modules/.pnpm/@umijs [email protected]_jest@29.7.0_@types [email protected][email protected]/node_modules/@umijs/fabric/dist/eslint.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
- To enable this feature, set early_access to true under in the settings.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

src/Tree.tsx (1)

1418-1419: 将样式和类名属性传递给上下文

将 styles 和 treeClassNames（作为 classNames）添加到上下文值中，使这些属性在组件树中的所有子组件都可以访问。

建议为这些新属性添加单元测试，确保它们能正确地从 Tree 组件传递到 TreeNode 组件，并验证样式和类名应用得当。

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cc6de94 and fb2b985.

📒 Files selected for processing (3)

src/Tree.tsx (3 hunks)
src/TreeNode.tsx (6 hunks)
tests/Tree.spec.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

src/TreeNode.tsx
tests/Tree.spec.tsx

🔇 Additional comments (3)

src/Tree.tsx (3)

86-86: 定义了语义化类型 SemanticName

这个新增的类型标记了树组件中可以应用样式和类名的特定元素：项目图标、项目和项目标题。这为样式定制提供了类型安全的基础。

91-92: 添加了语义化样式和类名支持

为 TreeProps 接口添加了 styles 和 classNames 属性，允许根据语义名称映射自定义样式和类名。这增强了组件的样式定制能力。

1369-1370: 从 props 中解构新属性

正确地从 props 中解构了 styles 和 classNames，并重命名 classNames 为 treeClassNames 以避免与内部变量冲突。

codecov · 2025-03-17T09:35:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (4ce3d40) to head (fb2b985).
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #928   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          14       14           
  Lines        1274     1275    +1     
  Branches      383      393   +10     
=======================================
+ Hits         1272     1273    +1     
  Misses          2        2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Yang-yibu · 2025-09-02T01:37:15Z

建议每一项支持函数方式设置，接收nodeData及level数据，如我的需求是不同层级的 Node 需要不同的样式

feat: support classNames and styles

58a1a93

vercel bot deployed to Preview March 16, 2025 03:27 View deployment

thinkasany mentioned this pull request Mar 16, 2025

feat(Tree): support classNames and styles for component and ConfigProvider ant-design/ant-design#53174

Merged

1 task

fix

cc6de94

vercel bot deployed to Preview March 16, 2025 15:10 View deployment

update

fb2b985

vercel bot deployed to Preview March 17, 2025 07:15 View deployment

coderabbitai bot reviewed Mar 17, 2025

View reviewed changes

zombieJ approved these changes Mar 19, 2025

View reviewed changes

zombieJ merged commit ccbf54a into react-component:master Mar 19, 2025
9 checks passed

This was referenced Mar 19, 2025

feat: support semantic for panel react-component/picker#923

Merged

feat: support classNames and styles react-component/tree-select#638

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support classNames and styles #928

feat: support classNames and styles #928

Uh oh!

thinkasany commented Mar 16, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Mar 16, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Mar 16, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

codecov bot commented Mar 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

Yang-yibu commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

feat: support classNames and styles #928

feat: support classNames and styles #928

Uh oh!

Conversation

thinkasany commented Mar 16, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Possibly related PRs

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Mar 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Yang-yibu commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

thinkasany commented Mar 16, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Mar 16, 2025 •

edited

Loading

coderabbitai bot commented Mar 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Mar 17, 2025 •

edited

Loading