Skip to content

[3.10] gh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (GH-32073) #97916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
miss-islington wants to merge 2 commits into from
Closed

[3.10] gh-88050: Fix asyncio subprocess to kill process cleanly when process is blocked (GH-32073) #97916

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea840e3
gh-88050: Fix asyncio subprocess to kill process cleanly when process…
kumaraditya303 Oct 5, 2022
de9906b
Reduce sleep time, to avoid overflow
gvanrossum Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Reduce sleep time, to avoid overflow 
Co-authored-by: Kumar Aditya <[email protected]>
  • Loading branch information
@gvanrossum @kumaraditya303
gvanrossum and kumaraditya303 authored Oct 5, 2022
commit de9906bf25a685de20540c29fcdd25dfab0eff6a
2 changes: 1 addition & 1 deletion Lib/test/test_asyncio/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def test_kill(self):
self.assertEqual(-signal.SIGKILL, returncode)

def test_kill_issue43884(self):
blocking_shell_command = f'{sys.executable} -c "import time; time.sleep(100000000)"'
blocking_shell_command = f'{sys.executable} -c "import time; time.sleep(100000)"'
creationflags = 0
if sys.platform == 'win32':
from subprocess import CREATE_NEW_PROCESS_GROUP
Expand Down