Skip to content

Conversation

@corona10
Copy link
Member

@corona10 corona10 commented Feb 3, 2021

@corona10 corona10 changed the title bpo-43106: Add os.O_EVTONLY for macOS bpo-43106: Add os.O_EVTONLY and os. O_FSYNC for macOS Feb 3, 2021
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's New.

Co-authored-by: Serhiy Storchaka <[email protected]>
@corona10
Copy link
Member Author

corona10 commented Feb 3, 2021

@serhiy-storchaka

What's New.

I intended to update What's New when we decide what flags will be added.
What do you think?

O_SYMLINK and O_NOFOLLOW_ANY are not yet added.

@corona10 corona10 changed the title bpo-43106: Add os.O_EVTONLY and os. O_FSYNC for macOS bpo-43106: Add os.O_EVTONLY and os.O_FSYNC for macOS Feb 3, 2021
@serhiy-storchaka
Copy link
Member

I think that all flags should be added. Even if they are not used in the stdlib, they can be used in third-party projects.

@corona10
Copy link
Member Author

corona10 commented Feb 3, 2021

I think that all flags should be added. Even if they are not used in the stdlib, they can be used in third-party projects.

Got it then I will add all flags through this PR and update the what's news

@corona10 corona10 changed the title bpo-43106: Add os.O_EVTONLY and os.O_FSYNC for macOS bpo-43106: Add os.O_EVTONLY/O_FSYNC/O_SYMLINK/O_NOFOLLOW_ANY Feb 3, 2021
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10
Copy link
Member Author

corona10 commented Feb 3, 2021

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@ronaldoussoren: please review the changes made to this pull request.

Copy link
Contributor

@ronaldoussoren ronaldoussoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 merged commit f917c24 into python:master Feb 3, 2021
@corona10 corona10 deleted the bpo-43106 branch February 3, 2021 23:33
@bedevere-bot
Copy link

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL7 3.x has failed when building commit f917c24.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/539/builds/601) and take a look at the build logs.
  4. Check if the failure is related to this commit (f917c24) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/539/builds/601

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

412 tests OK.

10 slowest tests:

  • test_concurrent_futures: 4 min 14 sec
  • test_unparse: 3 min 55 sec
  • test_capi: 3 min 19 sec
  • test_tokenize: 2 min 52 sec
  • test_multiprocessing_spawn: 2 min 52 sec
  • test_lib2to3: 2 min 21 sec
  • test_peg_generator: 2 min 18 sec
  • test_asyncio: 2 min 11 sec
  • test_gdb: 1 min 28 sec
  • test_multiprocessing_forkserver: 1 min 23 sec

1 test altered the execution environment:
test_asyncio

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 7 min 40 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/base_events.py", line 745, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants