-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Fix id of 'Internet Message Format' RFC in email doc #24137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this typo has been around for 5 years. Nice find!
There is also one more occurrence in email.compat32-message.rst, that should probably be updated too.
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress Extension". It seems that the actual reference should be "Internet Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322). (The typo probably comes from commit 29d1bc0 in which the ID of this RFC got updated from the obsolete 2822.) Co-authored-by: Ambrose Chua <[email protected]>
a9ebee9 to
55a20a7
Compare
serverwentdown
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, now links to the correct RFC.
|
This PR is stale because it has been open for 30 days with no activity. |
|
Thanks @dlax for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress Extension". It seems that the actual reference should be "Internet Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322). (The typo probably comes from commit 29d1bc0 in which the ID of this RFC got updated from the obsolete 2822.) Co-authored-by: Ambrose Chua <[email protected]> (cherry picked from commit cb5c802) Co-authored-by: Denis Laxalde <[email protected]>
|
GH-25613 is a backport of this pull request to the 3.9 branch. |
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress Extension". It seems that the actual reference should be "Internet Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322). (The typo probably comes from commit 29d1bc0 in which the ID of this RFC got updated from the obsolete 2822.) Co-authored-by: Ambrose Chua <[email protected]> (cherry picked from commit cb5c802) Co-authored-by: Denis Laxalde <[email protected]>
|
GH-25614 is a backport of this pull request to the 3.8 branch. |
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5232 (https://tools.ietf.org/html/rfc5322).
(The typo probably comes from commit 29d1bc0#diff-7728cd0eb5e471a8d52c0850e26560351f50ec6cb59d03bd5646bf492d80eb24 in which the ID of
this RFC got updated from the obsolete 2822.)