bpo-38237: Make pow's arguments have more descriptive names and be keyword passable #16302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This looks good :-) I'll go through it in more detail shortly. |
rhettinger
approved these changes
Sep 21, 2019
Contributor
|
@ammaraskar: Status check is done, and it's a success ✅ . |
| mod: object = None | ||
| Equivalent to x**y (with two arguments) or x**y % z (with three arguments) | ||
| Equivalent to base**exp (with two arguments) or base**exp % mod (with three arguments) |
Member
There was a problem hiding this comment.
This line is too long.
Contributor
|
Thanks @ammaraskar for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-16320 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 21, 2019
…yword passable (pythonGH-16302) Edit: `math.pow` changes removed on Mark's request. https://bugs.python.org/issue38237 Automerge-Triggered-By: @rhettinger (cherry picked from commit 87d6cd3) Co-authored-by: Ammar Askar <[email protected]>
rhettinger
pushed a commit
that referenced
this pull request
Sep 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit:
math.powchanges removed on Mark's request.https://bugs.python.org/issue38237
Automerge-Triggered-By: @rhettinger