bpo-37268: Add deprecation notice and a DeprecationWarning for the parser module #15017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Let's deprecate this once and for all! ⚔️ |
pablogsal
commented
Jul 30, 2019
|
|
||
| if (PyErr_WarnEx(PyExc_DeprecationWarning, | ||
| "The parser module is deprecated and will be removed " | ||
| "in future versions of Python", 7) != 0) { |
Member
Author
There was a problem hiding this comment.
7 is the magic number to skip all importlib._bootstrap_external (tested in test_deprecation_message). 🙃
vstinner
reviewed
Jul 30, 2019
Member
vstinner
left a comment
There was a problem hiding this comment.
You should document the deprecation around https://docs.python.org/dev/whatsnew/3.9.html#deprecated
Member
Author
Done! |
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…rser module (pythonGH-15017) Deprecate the parser module and add a deprecation warning triggered on import and a warning block in the documentation. https://bugs.python.org/issue37268 Automerge-Triggered-By: @pablogsal
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…rser module (pythonGH-15017) Deprecate the parser module and add a deprecation warning triggered on import and a warning block in the documentation. https://bugs.python.org/issue37268 Automerge-Triggered-By: @pablogsal
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
…rser module (pythonGH-15017) Deprecate the parser module and add a deprecation warning triggered on import and a warning block in the documentation. https://bugs.python.org/issue37268 Automerge-Triggered-By: @pablogsal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the parser module and add a deprecation warning triggered on import and a warning block in the documentation.
https://bugs.python.org/issue37268
Automerge-Triggered-By: @pablogsal