Skip to content

GH-116946: Eliminate the need for the GC in the _thread.lock and _thread.RLock #141268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kumaraditya303 merged 1 commit into from
Nov 12, 2025
Merged

GH-116946: Eliminate the need for the GC in the _thread.lock and _thread.RLock #141268

kumaraditya303 merged 1 commit into from
Nov 12, 2025

Conversation

@sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Nov 8, 2025 •
edited by bedevere-app bot
Loading

From #116946 (comment):

There are a number of heap types which are currently unnecessary gc types like _thread.lock, it would be nice to remove that as it would reduce memory usage and reduce pressure on gc, in case anyone wants to work on it.

@bedevere-app bedevere-app bot mentioned this pull request Nov 8, 2025
Open
@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Nov 8, 2025

@kumaraditya303 Could you please take a look?

@kumaraditya303 kumaraditya303 merged commit fbebca2 into python:main Nov 12, 2025
52 checks passed
@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Nov 12, 2025

Thanks!

kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Nov 12, 2025
@kumaraditya303
Revert "pythonGH-116946: eliminate the need for the GC in the `_threa…
edc8a07 
…d.lock` and `_thread.RLock` (python#141268)"

This reverts commit fbebca2.
kumaraditya303 added a commit that referenced this pull request Nov 12, 2025
@kumaraditya303
GH-116946: revert eliminate the need for the GC in the _thread.lock…
f1b7961 
… and `_thread.RLock` (#141448)

Revert "GH-116946: eliminate the need for the GC in the `_thread.lock` and `_thread.RLock` (#141268)"

This reverts commit fbebca2.
@efimov-mikhail efimov-mikhail added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 12, 2025
@bedevere-bot
Copy link

bedevere-bot commented Nov 12, 2025

🤖 New build scheduled with the buildbot fleet by @efimov-mikhail for commit fb0dc6f 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F141268%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Nov 12, 2025
@efimov-mikhail
Copy link
Member

efimov-mikhail commented Nov 12, 2025 •
edited
Loading

Oh, it seems that 🔨 test-with-buildbots label can't make something useful after PR have been merged.
Probably, that's okay.

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@sergey-miryanov @StanFromIreland
pythonGH-116946: eliminate the need for the GC in the _thread.lock …
275d346 
…and `_thread.RLock` (python#141268)
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@kumaraditya303 @StanFromIreland
pythonGH-116946: revert eliminate the need for the GC in the `_thread…
14b01a1 
….lock` and `_thread.RLock` (python#141448)

Revert "pythonGH-116946: eliminate the need for the GC in the `_thread.lock` and `_thread.RLock` (python#141268)"

This reverts commit fbebca2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sergey-miryanov @bedevere-bot @efimov-mikhail @kumaraditya303