Skip to content

gh-83714: Only use STATX_MNT_ID & STATX_SUBVOL if they're defined #140446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
encukou merged 3 commits into from
Oct 22, 2025
Merged

gh-83714: Only use STATX_MNT_ID & STATX_SUBVOL if they're defined #140446

encukou merged 3 commits into from
Oct 22, 2025

Conversation

@encukou
Copy link
Member

@encukou encukou commented Oct 22, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Oct 22, 2025
Closed
@encukou
Copy link
Member Author

encukou commented Oct 22, 2025

!buildbot AMD64.CentOS9.NoGIL

@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2025

🤖 New build scheduled with the buildbot fleet by @encukou for commit e879800 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR

@encukou
Copy link
Member Author

encukou commented Oct 22, 2025

!buildbot AMD64.CentOS9.NoGIL$

@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2025

The regex 'AMD64.CentOS9.NoGIL$' did not match any buildbot builder. Is the requested builder in the list of stable builders?

@encukou
Copy link
Member Author

encukou commented Oct 22, 2025

!buildbot AMD64.CentOS9.NoGIL

@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2025

🤖 New build scheduled with the buildbot fleet by @encukou for commit f0d5edb 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR

vstinner
vstinner approved these changes Oct 22, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I wrote a similar change before seeing yours :-)

@vstinner
Copy link
Member

vstinner commented Oct 22, 2025

Oh sorry, I created a conflict when I merged my other statx() change.

@encukou
Copy link
Member Author

encukou commented Oct 22, 2025

!buildbot AMD64.CentOS9.NoGIL

@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2025

🤖 New build scheduled with the buildbot fleet by @encukou for commit 0c95f7a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F140446%2Fmerge

The command will test the builders whose names match following regular expression: AMD64.CentOS9.NoGIL

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 NoGIL Refleaks PR

@encukou
Copy link
Member Author

encukou commented Oct 22, 2025

Could you please run buildbots for any other statx changes?

@encukou encukou merged commit e53e9eb into python:main Oct 22, 2025
45 checks passed
@encukou encukou deleted the guard-subvol branch October 22, 2025 10:42
@vstinner
Copy link
Member

vstinner commented Oct 22, 2025

Could you please run buildbots for any other statx changes?

Ok, I will. We ran buildbots on the change causing the regression, but only some buildbots.

StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@encukou @StanFromIreland
pythongh-83714: Only use STATX_MNT_ID & STATX_SUBVOL if they're defin…
4d159c6 
…ed (pythonGH-140446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@encukou @bedevere-bot @vstinner