-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
bpo-35246: fix support for path-like args in asyncio subprocess #13628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
miss-islington
merged 4 commits into
python:master
from
lilydjwg:asyncio-subprocess-path-args
May 29, 2019
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
d7dc435
bpo-35246: fix support for path-like args in asyncio subprocess
lilydjwg b69e116
improve test_subprocess
lilydjwg d517ded
Merge remote-tracking branch 'upstream/master' into asyncio-subproces…
lilydjwg e337a71
use test.support.FakePath instead of pathlib.Path
lilydjwg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
bpo-35246: fix support for path-like args in asyncio subprocess
drop isinstance checks from create_subprocess_exec function and let subprocess module do them.
- Loading branch information
commit d7dc43568a71ccda5079441b7829cfe3de36c9dc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -622,6 +622,18 @@ async def execute(): | |
| self.loop.run_until_complete(execute()) | ||
|
|
||
|
|
||
| def test_create_subprocess_exec_with_path(self): | ||
| async def execute(): | ||
| from pathlib import Path | ||
| p = await subprocess.create_subprocess_exec( | ||
| Path(sys.executable), '-c', 'pass') | ||
| await p.wait() | ||
| p = await subprocess.create_subprocess_exec( | ||
| sys.executable, '-c', 'pass', Path('.')) | ||
| await p.wait() | ||
|
|
||
| self.loop.run_until_complete(execute()) | ||
|
||
|
|
||
| if sys.platform != 'win32': | ||
| # Unix | ||
| class SubprocessWatcherMixin(SubprocessMixin): | ||
|
|
||
1 change: 1 addition & 0 deletions
1
Misc/NEWS.d/next/Library/2019-05-28-23-17-35.bpo-35246.oXT21d.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Make :func:`asyncio.create_subprocess_exec` accept path-like arguments. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the import to the top of the module.
Use
import pathlibform andpathlib.Pathfor consistency.