Skip to content

GH-111485: Increment next_instr consistently at the start of the instruction. #111486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 7 commits into from
Oct 31, 2023
Merged

GH-111485: Increment next_instr consistently at the start of the instruction. #111486

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
82d166b
Use instr_ptr instead of next_instr-1 in many places
markshannon Oct 27, 2023
e86ea39
Move next_instr increment to start of instruction.
markshannon Oct 27, 2023
a23102c
Don't define 'here' unless it is used
markshannon Oct 30, 2023
bdacb4e
Change a few 'frame->instr_ptr' to 'here'
markshannon Oct 30, 2023
2b28198
Change 'here' to 'this_instr' in bytecodes.c and generated cases
markshannon Oct 30, 2023
79bce6b
Merge branch 'main' into increment-next-instr-consistently
markshannon Oct 30, 2023
ad0616a
Use 'this_instr' more widely
markshannon Oct 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use instr_ptr instead of next_instr-1 in many places
  • Loading branch information
@markshannon
markshannon committed Oct 27, 2023
commit 82d166bd42bcf51877d6db70b8ca58481dd59092
1 change: 1 addition & 0 deletions Include/internal/pycore_opcode_metadata.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions Python/abstract_interp_cases.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading